Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BuildAh to 1.23.3 #1064

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented May 18, 2022

Changes

There is finally a new BuildAh version on quay, https://quay.io/repository/containers/buildah?tab=tags&tag=latest. Picking that and hoping that it resolves the problem with our hanging BuildRuns in the e2e test in GitHub actions.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

The sample build strategies have been updated to use the most recent BuildAh image, v1.23.3

@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label May 18, 2022
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label May 18, 2022
@openshift-ci openshift-ci bot requested review from adambkaplan and gabemontero May 18, 2022 13:51
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.10.0 milestone May 18, 2022
@SaschaSchwarze0 SaschaSchwarze0 changed the title Update BuildAh o 1.23.3 Update BuildAh to 1.23.3 May 18, 2022
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-update-buildah branch from 342d9c2 to 49d2214 Compare May 18, 2022 21:19
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

long waited!

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit 1351430 into shipwright-io:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants