Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose GOCACHE as volume in ko build strategy #1068

Merged

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Extending the ko build strategy with volume support for GOCACHE. This speeds up rebuilds dramatically when a Build user enables it. The build strategy by default uses an emptyDir which means that no caching happens. A Build user can assign any writable volume type to enable caching.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

The ko sample build strategy now supports a gocache volume that you can assign a writable volume in your Build to speed up rebuilds

@SaschaSchwarze0 SaschaSchwarze0 added the kind/feature Categorizes issue or PR as related to a new feature. label May 23, 2022
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.10.0 milestone May 23, 2022
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label May 23, 2022
@SaschaSchwarze0
Copy link
Member Author

fyi @rolfedh contains a small documentation change

@rolfedh
Copy link
Contributor

rolfedh commented May 24, 2022

fyi @rolfedh contains a small documentation change
Please go ahead and merge these changes - I'll transfer them to the asciidoc content.

@rolfedh
Copy link
Contributor

rolfedh commented May 25, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2022

@rolfedh: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rolfedh
Copy link
Contributor

rolfedh commented May 25, 2022

@SaschaSchwarze0. I have copied your new Volumes subsection from buildstrategies.md to buildstrategies.adoc in shipwright-io/website#79. Thanks.

@qu1queee qu1queee self-requested a review May 30, 2022 14:11
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2022
@qu1queee
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2022
@openshift-merge-robot openshift-merge-robot merged commit b41cd1b into shipwright-io:main May 30, 2022
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-ko-gocache branch August 5, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants