-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose GOCACHE as volume in ko build strategy #1068
Expose GOCACHE as volume in ko build strategy #1068
Conversation
fyi @rolfedh contains a small documentation change |
|
/lgtm |
@rolfedh: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@SaschaSchwarze0. I have copied your new Volumes subsection from buildstrategies.md to buildstrategies.adoc in shipwright-io/website#79. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
Extending the ko build strategy with volume support for GOCACHE. This speeds up rebuilds dramatically when a Build user enables it. The build strategy by default uses an emptyDir which means that no caching happens. A Build user can assign any writable volume type to enable caching.
Submitter Checklist
Release Notes