fix: avoid AWS-related error in kaniko container

[sbose78]

I can't seem to remember why this was removed.

E0403 03:28:54.670358      16 aws_credentials.go:77] while getting AWS credentials NoCredentialProviders: no valid providers in chain. Deprecated.
	For verbose messaging see aws.Config.CredentialsChainVerboseErrors

Changes

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Fix source-to-image strategy's kaniko step to ignore missing AWS credentials

[SaschaSchwarze0]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SaschaSchwarze0]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[SaschaSchwarze0]

I guess, we only added it for Kaniko but forgot the s2i strategy.

[openshift-ci-robot]

@sbose78: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[qu1queee]

@sbose78 can you resolve the conflicts and remove the WIP from the title, so that we can get this one merged please .

[sbose78]

Done!

[SaschaSchwarze0]

Re-opening to restart GitHub tests.

[SaschaSchwarze0]

/lgtm

[SaschaSchwarze0]

Just capturing for now. There is a failure in buildah which does not sound intermittent:

Logs of container step-buildah-bud:
STEP 1: FROM golang:1.16 AS build
STEP 2: FROM scratch
error creating build container: short-name resolution enforced but cannot prompt without a TTY

I trigger one more try.

[SaschaSchwarze0]

@sbose78 you need to rebase again to pick up the version pinning for buildah so that your tests pass. Also, please remove the WIP prefix from the PR name. Thank you.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SaschaSchwarze0]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[SaschaSchwarze0]

/lgtm