Extend the Buildpack strategy to work with the environment variables #906
Conversation
We noticed a shortcoming of the Buildpacks build strategy: as we bypass pack, the environment variables are not working. Extend the buildstrategy_buildpacks-v3_cr.yaml with the script to process environment variables. Add a test case to verify the environment variables working with Buildpack.
openshift-ci
bot
added
the
release-note-none
shahulsonhal
changed the title
|
|
||
| for env in "${envs[@]}"; do | ||
| IFS='=' read -r key value string <<< "$env" | ||
| if [[ "$key" != "" && "$value" != "" ]]; then |
There was a problem hiding this comment.
Let's not ignore empty values. There might be theoretic use cases where "not present" vs "empty string" makes a difference.
| if [[ "$key" != "" && "$value" != "" ]]; then | |
| if [[ "$key" != "" ]]; then |
| IFS='=' read -r key value string <<< "$env" | ||
| if [[ "$key" != "" && "$value" != "" ]]; then | ||
| path="${ENV_DIR}/${key}" | ||
| echo "--> Writing ${path}..." |
There was a problem hiding this comment.
This might be very noisy. I personally would remove the echos.
|
I do not feel good about having a |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
@coreydaley Thanks. I have replaced |
SaschaSchwarze0
added
kind/feature
openshift-ci
bot
added
release-note
|
/retest |
shahulsonhal
force-pushed
the
prepare-platform-env
branch
from
871cc1f to
3d6b833
Compare
shahulsonhal
force-pushed
the
prepare-platform-env
branch
from
3d6b833 to
afb462c
Compare
Changes
We noticed a shortcoming of the
Buildpacksbuild strategy: as we bypass pack, the environment variables are not working.Extend the
buildstrategy_buildpacks-v3_cr.yamlwith the script to process environment variables.Add a test case to verify the environment variables working with the
Buildpackbuild strategy.Note: This PR has a dependency with shipwright-io/sample-go#6. The test cases will only pass after merging the shipwright-io/sample-go#6.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes