Adds branchName in buildrun results if revision is not specified

[sm43]

If user doesn't specify revision in Build object, then default
branch is used.
This patch adds support for adding the branch name in BuildRun results
if revision is not specified in Build Object.

Fixes #923

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Adds branchName in buildrun results if revision is not specified in Build

[SaschaSchwarze0]

Very nice work @sm43. Code and tests are all perfect. I only look for an extension of https://github.com/shipwright-io/build/blob/main/docs/buildrun.md#step-results-in-buildrun-status to document the new status field. Edit: and I just approved the test runs, have a look at the failure. Should be easy to fix.

[sm43]

Very nice work @sm43. Code and tests are all perfect. I only look for an extension of https://github.com/shipwright-io/build/blob/main/docs/buildrun.md#step-results-in-buildrun-status to document the new status field. Edit: and I just approved the test runs, have a look at the failure. Should be easy to fix.

Thanks @SaschaSchwarze0
Fixed most of them but not sure why the below test is failing 🤔

Git Resource
/home/smukhade/go/src/github.com/shipwright-io/build/cmd/git/main_test.go:22
  cloning repositories with submodules
  /home/smukhade/go/src/github.com/shipwright-io/build/cmd/git/main_test.go:330
    should Git clone a repository with a submodule [It]
    /home/smukhade/go/src/github.com/shipwright-io/build/cmd/git/main_test.go:333

    Unexpected error:
        <*fs.PathError | 0xc0006842d0>: {
            Op: "open",
            Path: "",
            Err: <syscall.Errno>0x2,
        }
        open : no such file or directory
    occurred

    /home/smukhade/go/src/github.com/shipwright-io/build/cmd/git/main_test.go:338

any idea?
also how do I trigger the CI? is there any command I need comment to trigger it?

[SaschaSchwarze0]

also how do I trigger the CI? is there any command I need comment to trigger it?

Some maintainer needs to do this for you until you become a regular contributor.

[SaschaSchwarze0]

Okay, let's see if the tests get green now. One final request for the documentation.

[gabemontero]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbose78]

+1 on this, this is very helpful.

[SaschaSchwarze0]

/lgtm