Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign released images #938

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

imjasonh
Copy link
Contributor

@imjasonh imjasonh commented Nov 5, 2021

Changes

Progress toward #907

This also annotates the signature with the commit SHA and GitHub run ID and attempt number (in case there are multiple attempts), so consumers can trace back to the workflow run that produced the image and signature.

/kind feature

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Released images are signed with an ephemeral key using cosign

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Label for when a PR has specified a release note kind/feature Categorizes issue or PR as related to a new feature. labels Nov 5, 2021
@imjasonh imjasonh marked this pull request as ready for review December 7, 2021 18:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2021
@imjasonh
Copy link
Contributor Author

imjasonh commented Dec 7, 2021

I'd like to propose this before the next upcoming release. Nightly releases have been signed for a month or so without any issue AFAIK. Any concerns with signing the next release?

@imjasonh imjasonh added this to the release-v0.7.0 milestone Dec 7, 2021
@imjasonh
Copy link
Contributor Author

imjasonh commented Dec 8, 2021

PIng @adambkaplan @SaschaSchwarze0 any concerns with this?

I see in shipwright-io/community#45 that the code freeze for the next build release may be tomorrow?

Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2021
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I think we should cut a "release candidate" tomorrow so that the cli, website, and operator can get a head start syncing content. Let's use this as an opportunity to verify the image signature!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit 05251c4 into shipwright-io:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants