-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign released images #938
Sign released images #938
Conversation
7490f6d
to
271b783
Compare
I'd like to propose this before the next upcoming release. Nightly releases have been signed for a month or so without any issue AFAIK. Any concerns with signing the next release? |
PIng @adambkaplan @SaschaSchwarze0 any concerns with this? I see in shipwright-io/community#45 that the code freeze for the next build release may be tomorrow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I think we should cut a "release candidate" tomorrow so that the cli, website, and operator can get a head start syncing content. Let's use this as an opportunity to verify the image signature!
Changes
Progress toward #907
This also annotates the signature with the commit SHA and GitHub run ID and attempt number (in case there are multiple attempts), so consumers can trace back to the workflow run that produced the image and signature.
/kind feature
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes