Adds support for specifying image labels and annotation in buildrun #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
openshift-ci
bot
added
do-not-merge/release-note-label-needed
|
/kind feature |
openshift-ci
bot
added
the
kind/feature
|
@SaschaSchwarze0 Could you please take a look if the approach looks good? and |
SaschaSchwarze0
requested changes
Nov 16, 2021
openshift-ci
bot
added
release-note
This adds support for specifying image labels and annotations in buildrun. While generating the taskrun spec, the labels annotation will merged with the ones specified in build object. Values in buildrun will task precedence over in build. Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
sm43
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
4 tasks
SaschaSchwarze0
approved these changes
Nov 22, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for specifying image labels and annotations in
buildrun. While generating the taskrun spec, the labels annotation
will merged with the ones specified in build object. Values in
buildrun will task precedence over in build.
Part of #922
Signed-off-by: Shivam Mukhade smukhade@redhat.com
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes