Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect flag name #953

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Fix incorrect flag name #953

merged 1 commit into from
Dec 1, 2021

Conversation

HeavyWombat
Copy link
Contributor

Changes

The flag name was changed during the initial commit, but not updated in the
controller code.

Fix name to be "--git-url-rewrite".

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Fixed incorrect flag name for Git step in controller code.

@HeavyWombat
Fix incorrect flag name
2779fff 
The flag name was changed during the initial commit, but not updated in the
controller code.

Fix name to be `"--git-url-rewrite"`.
@HeavyWombat HeavyWombat added the kind/bug Categorizes issue or PR as related to a bug. label Dec 1, 2021
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Dec 1, 2021
@openshift-ci openshift-ci bot requested a review from adambkaplan December 1, 2021 08:48
SaschaSchwarze0
SaschaSchwarze0 approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit dc719a7 into shipwright-io:main Dec 1, 2021
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.7.0 milestone Dec 9, 2021
@wanjunlei wanjunlei mentioned this pull request Dec 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Milestone
release-v0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HeavyWombat @SaschaSchwarze0 @openshift-merge-robot