Remove compatability code to remove service account with -sa suffix #957
Conversation
SaschaSchwarze0
added
the
kind/cleanup
openshift-ci
bot
added
the
release-note
|
/approve should we have in previous PRs updated the doc for the generate SAs at https://github.com/shipwright-io/build/blob/main/docs/buildrun.md#defining-the-serviceaccount with some expectation of what the name of the generated service account is? if so, perhaps we can address that with this one WDYT @SaschaSchwarze0 ? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Done @gabemontero. |
| if apierrors.IsNotFound(err) { | ||
| serviceAccount.Name = GetHeritageGeneratedServiceAccountName(completedBuildRun) | ||
| ctxlog.Info(ctx, "deleting service account", namespace, completedBuildRun.Namespace, name, completedBuildRun.Name, "serviceAccount", serviceAccount.Name) | ||
| err = client.Delete(ctx, serviceAccount) | ||
| } | ||
|
|
||
| if err != nil && !apierrors.IsNotFound(err) { | ||
| if !apierrors.IsNotFound(err) { |
There was a problem hiding this comment.
I think it would be nice if we remove the nested if and use the &&
if err := client.Delete(ctx, serviceAccount); err != nil && !apierrors.IsNotFound(err) {
return err
}
There was a problem hiding this comment.
Indeed, done @shahulsonhal.
SaschaSchwarze0
force-pushed
the
sascha-remove-compat-code
branch
from
5960bf3 to
2100eee
Compare
Changes
Fixes #892
This removes the compatibility code that removes a generated service account with the
-sasuffix on BuildRun completion created by old releases. Should a user have a running old BuildRun or make a large version jump, then the owner reference will make sure the service account gets deleted on BuildRun deletion.Submitter Checklist
Release Notes