Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ioncube doesn't install on php 7.2 #856

Closed
3 tasks done
jocel1 opened this issue Jul 2, 2024 · 7 comments
Closed
3 tasks done

Ioncube doesn't install on php 7.2 #856

jocel1 opened this issue Jul 2, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@jocel1
Copy link

jocel1 commented Jul 2, 2024

Describe the bug
Since the latest bumpup of the v2 tag, ioncube doesn't install anymore on v2
When using 2.29.0 release everything works properly
Version

  • I have checked releases, and the bug exists in the latest patch version of v1 or v2.
  • v2

Runners

  • GitHub Hosted

Operating systems
ubuntu-latest

PHP versions
7.2

To Reproduce
- name: Setup PHP with PECL extension
uses: shivammathur/setup-php@v2
with:
php-version: 7.2
extensions: intl, mbstring, gd, apcu, memcached, ioncube
coverage: xdebug

Expected behavior
Properly install ioncube

Screenshots/Logs
image

2.29.0:

image
@jocel1 jocel1 added the bug Something isn't working label Jul 2, 2024
@shivammathur
Copy link
Owner

@jocel1
Please try running the workflow again, I'm unable to reproduce the issue
Test workflow: https://github.com/shivammathur/test-setup-php/actions/runs/9759633744/job/26936713788#step:2:19

@jocel1
Copy link
Author

jocel1 commented Jul 2, 2024

Same issue after several retry. I'm also using cache-extensions module, I'll try without it:

  code-quality:
    timeout-minutes: 20
    runs-on: ubuntu-latest
    strategy:
      matrix:
        php-versions: ['7.2']
    env:
      extensions: intl, mbstring, gd, apcu, memcached, ioncube
      key: cache-v1
    name: Code Quality on PHP ${{ matrix.php-versions }}
    permissions:
      contents: 'read'
      id-token: 'write'

      - name: Setup cache environment
        id: extcache
        uses: shivammathur/cache-extensions@v1
        with:
          php-version: ${{ matrix.php-versions }}
          extensions: ${{ env.extensions }}
          key: ${{ env.key }}

      - name: Cache extensions
        uses: actions/cache@v4
        with:
          path: ${{ steps.extcache.outputs.dir }}
          key: ${{ steps.extcache.outputs.key }}
          restore-keys: ${{ steps.extcache.outputs.key }}

      - name: Setup PHP with PECL extension
        uses: shivammathur/setup-php@v2
        with:
          php-version: ${{ matrix.php-versions }}
          extensions: ${{ env.extensions }}
          coverage: xdebug

@jocel1
Copy link
Author

jocel1 commented Jul 2, 2024

I confirm the issue comes from the caching.
When the cache doesn't exist, ioncube installation works properly.
However once the cache exists, it fails (I've just tried bumping the cache id the cache-v2 to force a cache reset, same issue)

@jocel1
Copy link
Author

jocel1 commented Jul 2, 2024

Note caching and 2.29.0 works properly.
It seems to start failing on 2.30.5, I suspect #840 to be involved in this issue :)

@jocel1
Copy link
Author

jocel1 commented Jul 2, 2024

2.30.4:
image

2.30.5 without caching:
image

2.30.5 with caching:
image

@shivammathur
Copy link
Owner

Ah!, Fixed in afff805. It will be in the next release.

@shivammathur shivammathur added the awaiting-release Added/Fixed and tested, awaiting release label Jul 2, 2024
@shivammathur
Copy link
Owner

Released 2.31.1 with the fix.

@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants