You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to some limitations, setting redirects for default domain does not behave as expected afterwards.
You need to use config options or env vars instead (INVALID_SHORT_URL_REDIRECT_TO, BASE_URL_TO, REGULAR_404_REDIRECT_TO).
We should deprecate that config, create new one with the DEFAULT_ prefix (and probably without the _TO suffix) that acts as fallback for any domain without a specific value, and then make sure the default domain can also have it's own redirects handled as for any other domain.
Additionally, the GET /domains endpoint should return a new prop with the default redirects, so that API consumers can know which is going to be the fallback behavior.
Currently, this can be inferred by checking the redirects of the default domain.
Summary
Due to some limitations, setting redirects for default domain does not behave as expected afterwards.
You need to use config options or env vars instead (
INVALID_SHORT_URL_REDIRECT_TO
,BASE_URL_TO
,REGULAR_404_REDIRECT_TO
).We should deprecate that config, create new one with the
DEFAULT_
prefix (and probably without the_TO
suffix) that acts as fallback for any domain without a specific value, and then make sure the default domain can also have it's own redirects handled as for any other domain.INVALID_SHORT_URL_REDIRECT_TO
->DEFAULT_INVALID_SHORT_URL_REDIRECT
REGULAR_404_REDIRECT_TO
->DEFAULT_REGULAR_404_REDIRECT
BASE_URL_REDIRECT_TO
->DEFAULT_BASE_URL_REDIRECT
Additionally, the
GET /domains
endpoint should return a new prop with the default redirects, so that API consumers can know which is going to be the fallback behavior.Currently, this can be inferred by checking the redirects of the default domain.
DomainRepository::findDomainsWithout
toDomainRepository::findDomains
, as it no longer uses the first argument.The text was updated successfully, but these errors were encountered: