Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure request ID is calculated on every request #1286

Closed
acelaya opened this issue Dec 19, 2021 · 0 comments
Closed

Make sure request ID is calculated on every request #1286

acelaya opened this issue Dec 19, 2021 · 0 comments
Labels
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Dec 19, 2021

Currently, the RequestIdMiddleware is piped for rest requests only, but the value is then ulogged for all requests, making non-rest requests log the latest generated ID, and therefore, using duplicated IDs, which should never happen.

This is not only wrong, but also, non-rest requests should also receibe their own ID for proper tracking of the tasks triggered by a non-rest request.

@acelaya acelaya added the bug label Dec 19, 2021
@acelaya acelaya added this to the 2.10.1 milestone Dec 19, 2021
@acelaya acelaya closed this as completed Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant