Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

click delete visits in short URLS - stats - option, the visits were clear to zero, but it still shows number of stats on the overview panel and visits on the list of short URLS #2264

Closed
xyychenchen opened this issue Nov 14, 2024 · 4 comments · Fixed by #2268
Labels
Milestone

Comments

@xyychenchen
Copy link

Shlink version

4.2.5

PHP version

8.2.25

How do you serve Shlink

Self-hosted nginx

Database engine

MariaDB

Database version

10.11.6

Current behavior

I deleted all the access data in the leftmost option in the short link data panel. When I clicked on the short link data panel alone, it showed 0. However, when I went back to the overview or list of short URLs to check the access data, I found that there was no change. It still showed the original access data.

Expected behavior

The access data of the short link seen from all locations should be cleared

Minimum steps to reproduce

already made it clear

@acelaya
Copy link
Member

acelaya commented Nov 14, 2024

Yep, I can reproduce. I'll take a look.

@acelaya
Copy link
Member

acelaya commented Nov 14, 2024

I think it's very likely related with the changes introduced here #2074

That PR introduced a way to track visits counts separately than the actual visits table, to improve performance when only checking how many visits exist.

When deleting visits, it is apparently not cleaning the relevant entries there. I'll check why.

@acelaya acelaya moved this to In Progress in Shlink Nov 15, 2024
@acelaya acelaya added this to the 4.3.0 milestone Nov 15, 2024
@acelaya acelaya moved this from In Progress to In review in Shlink Nov 15, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink Nov 15, 2024
@acelaya
Copy link
Member

acelaya commented Nov 15, 2024

This is fixed now. To be released with Shlink 4.3

@xyychenchen
Copy link
Author

This is fixed now. To be released with Shlink 4.3

thanks brother you are very professional, so I have to update to expect the new changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants