Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev console link not appearing #1310

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Conversation

matteodepalo
Copy link
Contributor

What the title says.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Benchmark report

The following table contains a summary of the startup time for all commands.

Status Command Baseline (avg) Current (avg) Diff
🟢 app build 1130.67 ms 1104.67 ms -2.3 %
🟢 app deploy 1397.33 ms 1377.67 ms -1.41 %
🟢 app dev 1389 ms 1353.33 ms -2.57 %
🟢 app env pull 1251.67 ms 1231 ms -1.65 %
🟢 app env show 1262.67 ms 1230 ms -2.59 %
🟢 app generate extension 1349.33 ms 1325.33 ms -1.78 %
🟢 app generate schema 1284.67 ms 1282.67 ms -0.16 %
🟢 app info 1280.33 ms 1236 ms -3.46 %
🟢 app scaffold extension 1363 ms 1336 ms -1.98 %
🟢 app update-url 1225.33 ms 1202.33 ms -1.88 %
🟢 theme check 1061 ms 1053.33 ms -0.72 %
🟢 theme delete 1218.33 ms 1201 ms -1.42 %
🟢 theme dev 1224 ms 1207.67 ms -1.33 %
🟢 theme help-old 1055 ms 1062.33 ms 0.7 %
🟢 theme info 1141 ms 1093.33 ms -4.18 %
🟢 theme init 1081 ms 1106.67 ms 2.37 %
🟢 theme language-server 1049.67 ms 1066.33 ms 1.59 %
🟢 theme list 1220 ms 1178 ms -3.44 %
🟢 theme open 1264.67 ms 1162.67 ms -8.07 %
🟢 theme package 1151.67 ms 1089.33 ms -5.41 %
🟢 theme publish 1180 ms 1179.67 ms -0.03 %
🟢 theme pull 1201 ms 1155.33 ms -3.8 %
🟢 theme push 1221 ms 1191.33 ms -2.43 %
🟢 theme serve 1208 ms 1186.67 ms -1.77 %
🟢 theme share 1183.33 ms 1194.67 ms 0.96 %
🟢 webhook trigger 1166 ms 1186.67 ms 1.77 %

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
71.77% (-0.01% 🔻)
3944/5495
🟡 Branches 69.15% 1780/2574
🟡 Functions 70.13% 1033/1473
🟡 Lines
73.02% (-0.01% 🔻)
3762/5152

Test suite run success

1010 tests passing in 518 suites.

Report generated by 🧪jest coverage report action from 9e7e226

@matteodepalo matteodepalo merged commit f408a52 into main Feb 8, 2023
@matteodepalo matteodepalo deleted the fix-dev-console-not-appearing branch February 8, 2023 08:39
@shopify-shipit shopify-shipit bot temporarily deployed to production February 8, 2023 08:58 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to nightly February 9, 2023 02:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants