Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help urls #1412

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix help urls #1412

merged 1 commit into from
Feb 21, 2023

Conversation

Arkham
Copy link
Contributor

@Arkham Arkham commented Feb 20, 2023

WHY are these changes introduced?

After generating a function we were pointing to incorrect help pages.

WHAT is this pull request doing?

Fix help URLS that we display

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions
Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "yarn changeset add" to track your changes and include them in the next release CHANGELOG.

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.88% 4114/5645
🟡 Branches 69.84% 1850/2649
🟡 Functions 70.67% 1089/1541
🟡 Lines 74.19% 3926/5292

Test suite run success

1041 tests passing in 535 suites.

Report generated by 🧪jest coverage report action from 80ffedb

Copy link

@kimbilida kimbilida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we can extract these URLs into a list that we can use to check their validity.

@Arkham Arkham merged commit ad05582 into main Feb 21, 2023
@Arkham Arkham deleted the fix-help-urls branch February 21, 2023 09:31
@shopify-shipit shopify-shipit bot temporarily deployed to nightly February 21, 2023 12:52 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to production February 22, 2023 16:13 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to stable_3_44 February 23, 2023 11:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants