Fix loading JS functions & Improve theme dev loading time #1418
Conversation
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
| ) { | ||
| await sleep(3) | ||
| if (shouldWait) await sleep(3) |
There was a problem hiding this comment.
wat? why were we sleeping in the first place?
There was a problem hiding this comment.
we need to.
The theme server is restarted every 2h (to refresh the tokens), but when we close a process and start a new one, there is chance that the port is not ready yet, so we need to wait a bit.
But that wait shouldn't happen on the first run, only when we restart the server.
There was a problem hiding this comment.
oh I see, it's not the end of the world then. In theory we could use functions from https://github.com/unjs/get-port-please (which we already have as a dep) to check if the port is available for use :)
There was a problem hiding this comment.
Yeah, it was a temporary solution, the idea is that dev should handle token refresh internally, but that won't happen until the command is ported from Ruby...
Coverage report
Test suite run success1056 tests passing in 534 suites. Report generated by 🧪jest coverage report action from 7925a40 |
WHY are these changes introduced?
Bugs found during the release QA
WHAT is this pull request doing?
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.