Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cli-main to cli #994

Merged
merged 6 commits into from
Jan 4, 2023
Merged

Rename cli-main to cli #994

merged 6 commits into from
Jan 4, 2023

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented Jan 3, 2023

WHY are these changes introduced?

We had to rename the cli directory to cli-main due to some issues with Vitest's mocking functionality.

WHAT is this pull request doing?

The issue is gone now so I'm renaming the directory back to cli to align it with the name of the package that it contains, @shopify/cli.

How to test your changes?

Tests should pass for all the packages.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@pepicrft pepicrft requested a review from a team January 3, 2023 14:00
@pepicrft pepicrft self-assigned this Jan 3, 2023
@pepicrft pepicrft requested review from isaacroldan and alvaro-shopify and removed request for a team January 3, 2023 14:00
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "yarn changeset add" to track your changes and include them in the next release CHANGELOG.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 67.76% 3512/5183
🟡 Branches
63.57% (+1.27% 🔼)
1443/2270
🟡 Functions 66.25% 893/1348
🟡 Lines
68.57% (+0.59% 🔼)
3347/4881
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴 cli/src/index.ts 0% 0% 0% 0%
🟢
... / editions.ts
100% 100% 100% 100%
🟢
... / kitchen-sink.ts
100% 100% 100% 100%
🟢
... / upgrade.ts
100% 100% 100% 100%
🟢
... / version.ts
100% 100% 100% 100%
🟢
... / logout.ts
100% 100% 100% 100%
🔴
... / kitchen-sink.ts
0% 100% 0% 0%
🟢
... / upgrade.ts
93.22% 85.71% 100% 94.74%
🟢
... / version.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / app.ts
61.22%
28.57% (-2.68% 🔻)
50% 64.44%
🟢
... / identifiers.ts
100%
87.5% (-12.5% 🔻)
100% 100%
🔴
... / functions.ts
44.44%
50% (-7.14% 🔻)
41.67% 44.44%
🟢
... / ui.ts
80%
66.67% (-1.75% 🔻)
78.95% 83.33%
🟢
... / extension.ts
83.33%
69.23% (-5.77% 🔻)
80% 88.46%
🟢
... / generate.ts
95.56%
89.29% (-1.19% 🔻)
88.89% 97.44%
🟢
... / info.ts
84.4%
55% (-7.96% 🔻)
85.71% 84.69%
🔴
... / upload.ts
47.95%
70% (-6% 🔻)
30.77% 50%
🔴
... / output.ts
38.64%
25% (-11.36% 🔻)
41.67% 36.84%
🟢
... / select-app.ts
100%
87.5% (-12.5% 🔻)
100% 100%
🟢
... / theme-extension-args.ts
100%
50% (-50% 🔻)
100% 100%
🟢
... / localization.ts
100%
87.5% (-12.5% 🔻)
100% 100%
🟢
... / templates.ts
100%
75% (-25% 🔻)
100% 100%
🟡
... / middlewares.ts
77.33%
73.08% (-1.92% 🔻)
70% 76.39%
🟢
... / handlers.ts
97.3%
66.67% (-19.05% 🔻)
100% 97.22%
🟢
... / bundle.ts
97.3%
85% (-7.86% 🔻)
100% 97.3%
🟢
... / trigger.ts
100%
87.5% (-12.5% 🔻)
100% 100%
🔴
... / http-reverse-proxy.ts
43.33%
38.46% (-11.54% 🔻)
28.57% 48.15%
🟢 cli-kit/src/git.ts 92.96%
85.71% (-1.24% 🔻)
93.33% 94.12%
🟢
... / metadata.ts
96%
87.5% (-12.5% 🔻)
100% 96%
🟡
... / monorail.ts
75%
50% (-16.67% 🔻)
100% 75%
🔴 cli-kit/src/os.ts 53.85%
65% (-6.43% 🔻)
50% 56.76%
🟡
... / output.ts
71.31%
65% (-1% 🔻)
61.36% 71.55%
🔴
... / store.ts
50.91%
62.5% (-5.68% 🔻)
40.91% 48.08%
🔴
... / system.ts
42.55%
35.71% (-0.65% 🔻)
33.33% 44.44%
🟢
... / admin.ts
84%
25% (-8.33% 🔻)
87.5% 84%
🟡
... / common.ts
62.96%
53.85% (-0.7% 🔻)
87.5% 61.54%
🟡
... / ui.tsx
76.92%
40% (-10% 🔻)
66.67% 76%
🟡
... / error-handler.ts
71.43%
78% (-1.55% 🔻)
55% 70.73%
🟢
... / node-package-manager.ts
94.74%
91.23% (-0.61% 🔻)
92% 94.74%
🔴
... / ruby.ts
48.86%
51.43% (-3.74% 🔻)
46.43% 51.81%
🟢
... / schema.ts
85.71%
50% (-16.67% 🔻)
100% 83.33%
🟢
... / store.ts
100%
50% (-50% 🔻)
100% 100%

Test suite run success

881 tests passing in 455 suites.

Report generated by 🧪jest coverage report action from ae130bf

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Benchmark report

The following table contains a summary of the startup time for all commands.

Status Command Baseline Current Diff
🟢 app build 1567 ms 1166 ms -25.59 %
🟢 app deploy 1616 ms 1236 ms -23.51 %
🟢 app dev 1573 ms 1216 ms -22.7 %
🟢 app env pull 1566 ms 1159 ms -25.99 %
🟢 app env show 1527 ms 1179 ms -22.79 %
🟢 app generate extension 1564 ms 1163 ms -25.64 %
🟢 app generate schema 1535 ms 1159 ms -24.5 %
🟢 app info 1489 ms 1154 ms -22.5 %
🟢 app scaffold extension 1550 ms 1175 ms -24.19 %
🟢 theme check 1493 ms 1131 ms -24.25 %
🟢 theme delete 1542 ms 1120 ms -27.37 %
🟢 theme dev 1517 ms 1128 ms -25.64 %
🟢 theme help-old 1512 ms 1130 ms -25.26 %
🟢 theme info 1469 ms 1128 ms -23.21 %
🟢 theme init 1536 ms 1142 ms -25.65 %
🟢 theme language-server 1462 ms 1137 ms -22.23 %
🟢 theme list 1460 ms 1128 ms -22.74 %
🟢 theme open 1518 ms 1138 ms -25.03 %
🟢 theme package 1467 ms 1134 ms -22.7 %
🟢 theme publish 1448 ms 1133 ms -21.75 %
🟢 theme pull 1505 ms 1147 ms -23.79 %
🟢 theme push 1470 ms 1154 ms -21.5 %
🟢 theme share 1477 ms 1134 ms -23.22 %
🟢 webhook trigger 1559 ms 1138 ms -27 %

@pepicrft pepicrft merged commit aab6d2a into main Jan 4, 2023
@pepicrft pepicrft deleted the cli-main-to-cli branch January 4, 2023 10:28
@shopify-shipit shopify-shipit bot temporarily deployed to production January 5, 2023 11:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants