-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename cli-main
to cli
#994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
requested review from
isaacroldan and
alvaro-shopify
and removed request for
a team
January 3, 2023 14:00
We detected some changes at packages/*/src and there are no updates in the .changeset. |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success881 tests passing in 455 suites. Report generated by 🧪jest coverage report action from ae130bf |
Benchmark reportThe following table contains a summary of the startup time for all commands.
|
pepicrft
force-pushed
the
cli-main-to-cli
branch
from
January 3, 2023 16:43
a6e9456
to
ae130bf
Compare
alvaro-shopify
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We had to rename the
cli
directory tocli-main
due to some issues with Vitest's mocking functionality.WHAT is this pull request doing?
The issue is gone now so I'm renaming the directory back to
cli
to align it with the name of the package that it contains,@shopify/cli
.How to test your changes?
Tests should pass for all the packages.
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.