Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for UnmarshalText and MarshalText for NullDecimal #193

Closed
bharath23 opened this issue Dec 4, 2020 · 3 comments
Closed

Add support for UnmarshalText and MarshalText for NullDecimal #193

bharath23 opened this issue Dec 4, 2020 · 3 comments

Comments

@bharath23
Copy link
Contributor

bharath23 commented Dec 4, 2020 •
edited
Loading

Like support for JSON it would be nice to have support for XML for NullDecimal.

I have submitted PR #192 which add support for it.
@mwoss
Copy link
Member

mwoss commented Dec 5, 2020

Thanks for submitting the pull reqeuest! I will try to look at it tomorrow.

@mwoss
Copy link
Member

mwoss commented Jan 10, 2021 •
edited
Loading

Closing, waiting for the PR author's response.

@mwoss mwoss closed this as completed Jan 10, 2021
@bharath23
Copy link
Contributor Author

Updated PR based on you comments.

@bharath23 bharath23 mentioned this issue Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bharath23 @mwoss