From 1d0d5be21ef932b0848f1e04074aba427bcc9f23 Mon Sep 17 00:00:00 2001
From: shota <miyafly7@gmail.com>
Date: Fri, 1 Sep 2023 00:51:09 +0900
Subject: [PATCH] refactoring

---
 src/main/flight/servos.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/src/main/flight/servos.c b/src/main/flight/servos.c
index 4d4bb497d19..fc0147ca3aa 100755
--- a/src/main/flight/servos.c
+++ b/src/main/flight/servos.c
@@ -104,7 +104,6 @@ int16_t servo[MAX_SUPPORTED_SERVOS];
 
 static uint8_t servoRuleCount = 0;
 static servoMixer_t currentServoMixer[MAX_SERVO_RULES*MAX_MIXER_PROFILE_COUNT];
-static bool currentServoMixerActivative[MAX_SERVO_RULES*MAX_MIXER_PROFILE_COUNT];// if true, the rule is used by current servo mixer
 static bool servoOutputEnabled;
 
 static bool mixerUsesServos;
@@ -194,7 +193,7 @@ void loadCustomServoMixer(void)
             }
 
             memcpy(&currentServoMixer[servoRuleCount], &tmp_customServoMixers[i], sizeof(servoMixer_t));
-            currentServoMixerActivative[servoRuleCount] = j==currentMixerProfileIndex;
+            currentServoMixer[servoRuleCount].rate = (j==currentMixerProfileIndex) ? currentServoMixer[servoRuleCount].rate : 0; //set rate to 0 if not active profile
             servoRuleCount++;
         }
     }
@@ -353,9 +352,6 @@ void servoMixer(float dT)
             inputRaw = 0;
         }
     #endif
-        if (!currentServoMixerActivative[i]) {
-            inputRaw = 0;
-        }
         /*
          * Apply mixer speed limit. 1 [one] speed unit is defined as 10us/s:
          * 0 = no limiting
@@ -438,7 +434,7 @@ void processServoAutotrimMode(void)
                 if (ARMING_FLAG(ARMED)) {
                     for (int axis = FD_ROLL; axis <= FD_YAW; axis++) {
                         for (int i = 0; i < servoRuleCount; i++) {
-                            if (!currentServoMixerActivative[i]) {continue;}
+                            if (currentServoMixer[i].rate==0) {continue;}
                                 // Reset servo middle accumulator
                             const uint8_t target = currentServoMixer[i].targetChannel;
                             const uint8_t source = currentServoMixer[i].inputSource;
@@ -461,7 +457,7 @@ void processServoAutotrimMode(void)
                 if (ARMING_FLAG(ARMED)) {
                     for (int axis = FD_ROLL; axis <= FD_YAW; axis++) {
                         for (int i = 0; i < servoRuleCount; i++) {
-                            if (!currentServoMixerActivative[i]) {continue;}
+                            if (currentServoMixer[i].rate==0) {continue;}
                             const uint8_t target = currentServoMixer[i].targetChannel;
                             const uint8_t source = currentServoMixer[i].inputSource;
                             if (source == axis) {
@@ -474,7 +470,7 @@ void processServoAutotrimMode(void)
                     if ((millis() - trimStartedAt) > SERVO_AUTOTRIM_TIMER_MS) {
                         for (int axis = FD_ROLL; axis <= FD_YAW; axis++) {
                             for (int i = 0; i < servoRuleCount; i++) {
-                                if (!currentServoMixerActivative[i]) {continue;}
+                                if (currentServoMixer[i].rate==0) {continue;}
                                 const uint8_t target = currentServoMixer[i].targetChannel;
                                 const uint8_t source = currentServoMixer[i].inputSource;
                                 if (source == axis) {
@@ -508,7 +504,7 @@ void processServoAutotrimMode(void)
         if (trimState == AUTOTRIM_SAVE_PENDING) {
             for (int axis = FD_ROLL; axis <= FD_YAW; axis++) {
                 for (int i = 0; i < servoRuleCount; i++) {
-                    if (!currentServoMixerActivative[i]) {continue;}
+                    if (currentServoMixer[i].rate==0) {continue;}
                     const uint8_t target = currentServoMixer[i].targetChannel;
                     const uint8_t source = currentServoMixer[i].inputSource;
                     if (source == axis) {