Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster - split DeleteGroups requests to ensure it is always routable. #1666

Closed
rukai opened this issue Jun 14, 2024 · 2 comments
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@rukai
Copy link
Member

rukai commented Jun 14, 2024

If the DeleteGroups request contains groups that have coordinators on separate brokers shotover currently just routes it to the coordinator of the first group.
The correct way to handle this is to split it into multiple requests and then rejoin the responses back into a single response.

First double check that this is actually a problem by writing an integration test that deletes multiple groups at once, if we dont hit any routing errors then maybe we dont actually need to split these requests.

Then, refer to the other messages that are split such as fetch and produce copying their logic to split DeleteGroups requests and recombine the DeleteGroups responses.

@rukai rukai added the bug Something isn't working label Jun 14, 2024
@rukai rukai added the good first issue Good for newcomers label Oct 3, 2024
@rukai
Copy link
Member Author

rukai commented Oct 3, 2024

I'm marking this as a good first issue since its largely copying logic that is already used elsewhere. But the splitting/combining logic is a bit complicated.

@rukai
Copy link
Member Author

rukai commented Oct 28, 2024

closed by #1785

@rukai rukai closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant