Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload way off #9

Closed
eripa opened this issue Mar 7, 2016 · 4 comments
Closed

Upload way off #9

eripa opened this issue Mar 7, 2016 · 4 comments

Comments

@eripa
Copy link

eripa commented Mar 7, 2016

Seems like the upload speed is way off (underlaying crash?). Server 7812 works fine. Can I help and debug?

Target Server: [5917] 21.17km Landskrona (Sweden) by Bredbandsson AB
Latency: 7.126748ms
Download Test: ................
Upload Test: ................

Download: 81.60 Mbit/s
Upload: 1928.76 Mbit/s

@showwin
Copy link
Owner

showwin commented Mar 7, 2016

Hi, I really appreciate you to report a bug. 😀
Does it happen every time when you test to the server 5917? I think you can get a good result if you try again.

The problem might be caused from here, and the denominator would be much small at that time.
This may because download request didn't go well in some reason (network problem or target server error, etc.). But I'm sorry, I'm not sure. 😞

Do you have any idea of this problem? (if not, I'll try change the request algorithm slightly to be more stable.)

@eripa
Copy link
Author

eripa commented Mar 8, 2016

Thanks for the quick feedback. Isn't it possible, as step 1, to try and catch this behaviour with a sanity check or some kind of error check. Either a) if the underlaying function crashes; catch the error and display an error message instead or b) if the upload speed is 100x the download speed show some warning message. :)

@showwin
Copy link
Owner

showwin commented Mar 8, 2016

Thank you for giving me many proposals.

as step 1, to try and catch this behaviour with a sanity check or some kind of error check.
a) if the underlaying function crashes; catch the error and display an error message instead

Yes, HTTP request error is already handled, and the target server status is checked before start measuring speed.

b) if the upload speed is 100x the download speed show some warning message.

This validation process sounds great. I'll implement it.

@showwin
Copy link
Owner

showwin commented Apr 19, 2016

Warning message is implemented at 79668c2, and released v1.0.2.

@showwin showwin closed this as completed Apr 19, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants