Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Center quotes #198

Open
krakxn opened this issue Sep 20, 2022 · 6 comments
Open

Enhancement: Center quotes #198

krakxn opened this issue Sep 20, 2022 · 6 comments

Comments

@krakxn
Copy link

krakxn commented Sep 20, 2022

The src content seems to not be symmetrical; consequently, it (quotes card) cannot be centered, even when offset w/ custom height and width.

This problem (centering) can only be fixed by fixing the src content (to be symmetrical)--especially since either align="left" and align="right" seem so unfitting.

Cheers!

@Ravina-Deogadkar
Copy link

Can I take this task?

@krakxn
Copy link
Author

krakxn commented Sep 25, 2022

Elaborate?

@shravan20
Copy link
Owner

Could add some images and elaborate it?

@krakxn
Copy link
Author

krakxn commented Sep 26, 2022

@shravan20 The Heroku instance which is responsible with deploying the application (quotes) is currently down; I will provide images when it's running again.

To elaborate, if the quotes are surrounded w/ <p> tags with align="center" they are, though in the middle, aligned very awkwardly in a way where it is aligned slightly to the left and right.

E.g. for a visual representation, assume it is the GitHub profile README, scenarios with align="" attribute with left, right, and center values.

1: Left and Right

image

2: Center

It is aligned like this in almost every scenario, and looks very awkwardly placed

image

A correct alignment would look like this (which it does not):

image

i.e. perfectly aligned center.


I am assuming that the cause of this can only be attributed to the fact that the src (i.e. the content) itself is of disproportional dimensions or a similar problem w/ the content.

@fathomer
Copy link
Contributor

Good find @krakxn

This issue is still there. Check this sample screenshot from @shravan20's readme. The quote is not centered and left margin is less than the right margin.
image

@4nshuman
Copy link
Contributor

hey @shravan20, seems to me that this issue was fixed by the PR from @fathomer.
Could you confirm if this issue still needs attention ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants