-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Handling regular signals sent to cargo-shuttle on Windows #1077
Conversation
Right now Implemented handler for Ctrl+C only, it can be extended to other ones. Would love to get some input on which one to add from https://docs.rs/tokio/latest/tokio/signal/windows/index.html. |
I think we need to handle all of them: https://learn.microsoft.com/en-us/windows/console/setconsolectrlhandler#remarks. A default handler for all these signals calls |
Added all the handlers, please review |
Seems like tests are failing because of |
@iulianbarbu passed all checks now. |
Thanks @Shubham8287 ! We just need to do some manual testing on a windows machine. We'll follow up after. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing worked well on my side @Shubham8287 ! thanks.
* Added Ctlc+C handler for windows * add all handlers * fix linting --------- Co-authored-by: Shubham Mishra <shubmishra@microsoft.com> Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com>
Description of change
Gracefully handling windows signal to interrupt local run for #872.
/claim #872
How has this been tested? (if applicable)
Tested by running on windows, with Ctrl+C