Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): inform project owner about running state #1194

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

thass0
Copy link
Contributor

@thass0 thass0 commented Sep 2, 2023

Description of change

cargo shuttle project start fails if the project already exists. If the existing project is owned by the caller of the command, new error messages are now displayed. They automatically provide the project owner with the current status of their project, and they indicate that her or his project is running. Depending on the current state, different hints are also provided.

Extends #1192

How has this been tested? (if applicable)

The assertions added in #1192 have been updated to match the changes.

Now, if `cargo shuttle project start` fails because the
existing project is owned by the caller, the information
from `cargo shuttle project status` is automatically displayed.
Depending on the running state, different hints are provided.

Extends shuttle-hq#1192
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @d4ckard! I just have one small comment about the Stopped state, and a naming nit 😄

gateway/src/service.rs Outdated Show resolved Hide resolved
common/src/models/error.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @d4ckard!

@jonaro00 jonaro00 merged commit 2fa1db3 into shuttle-hq:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants