Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(builder): improve the nix build capturing of stdout/stderr #1268

Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat(builder): improve the nix build capturing of stdout/stderr #1268

merged 2 commits into from
Sep 25, 2023

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Sep 22, 2023

Description of change

Utilize os_pipe to both capture stdout and stderr of nix build command.

How has this been tested? (if applicable)

In progress.

iulianbarbu
iulianbarbu approved these changes Sep 22, 2023
View reviewed changes
builder/src/lib.rs Show resolved Hide resolved
@iulianbarbu iulianbarbu merged commit 0b577b9 into shuttle-hq:main Sep 25, 2023
32 checks passed
iulianbarbu pushed a commit to GugaGongadze/shuttle that referenced this pull request Sep 27, 2023
@orhun @iulianbarbu
feat(builder): improve the nix build capturing of stdout/stderr (shut…
0c8c8f0 
…tle-hq#1268)

* feat(builder): improve the nix build capturing of stdout/stderr

* fix(builder): avoid a deadlock while reading stdout/stderr of nix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddgrd oddgrd oddgrd left review comments

@iulianbarbu iulianbarbu iulianbarbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orhun @iulianbarbu @oddgrd