Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cargo-shuttle): revert shuttle-common-tests to path dep #1375

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

oddgrd
Copy link
Contributor

@oddgrd oddgrd commented Nov 9, 2023

Description of change

cargo-shuttle failed to publish with shuttle-common-tests as a workspace dependency.

How has this been tested? (if applicable)

Tested cargo publish with --dry-run, then published the crate on this branch.

@jonaro00
Copy link
Member

jonaro00 commented Nov 9, 2023

Just add a comment about why, so we don't repeat the mistake :D

@oddgrd oddgrd merged commit 70ba489 into main Nov 10, 2023
33 checks passed
@oddgrd oddgrd deleted the fix/cargo-shuttle-dependency-bug branch November 10, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants