tests(auth): simplify auth service tests with wiremock #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes the tests more readable, since you don't need to know which index each mock has
jonaro00
pushed a commit
that referenced
this pull request
Jan 24, 2024
* tests(auth): simplify auth service tests with wiremock * tests(auth): use stripe mock consts directly in tests this makes the tests more readable, since you don't need to know which index each mock has
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Since we're not sure about merging #1478 and #1508, I extracted the testing refactor, simplifying the Stripe mocking a little bit. This should make it easier to write tests for the changes we're going to make when implementing RDS billing as a paid addon.
How has this been tested? (if applicable)
Updated the tests, they pass, as they did in #1478 and #1508.