Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AWS RDS #180

Merged
merged 62 commits into from
Jun 20, 2022
Merged

feat: AWS RDS #180

merged 62 commits into from
Jun 20, 2022

Conversation

chesedo
Copy link
Contributor

@chesedo chesedo commented May 18, 2022

Adds support for Postgres, Mysql and MariaDB AWS RDS

Needs #167

Breaking change

All old deploys that use the PgPool needs to add attribute configuration to explicitly ask for a shared Postgres resource as follow:

#[shuttle_service::main]
async fn rocket(#[shared::Postgres] pool: PgPool) -> Result<Rocket<Build>, shuttle_service::Error> {
    //          ^^^^^^^^^^^^^^^^^^^
    //                   |
    //                   This is the part to add

    // Business as usual here
}

@chesedo chesedo force-pushed the feat/rds branch 2 times, most recently from 49562a3 to db53405 Compare May 24, 2022 07:16
@chesedo chesedo marked this pull request as ready for review May 30, 2022 13:41
@chesedo chesedo requested a review from brokad May 30, 2022 13:42
@chesedo chesedo requested a review from bmoxb June 7, 2022 10:14
Copy link
Contributor

@bmoxb bmoxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks cool to me, the #[shared::Postgres], etc. proc-macro annotations are very funky :)

examples/tide/postgres/src/lib.rs Outdated Show resolved Hide resolved
examples/tide/postgres/src/lib.rs Outdated Show resolved Hide resolved
chesedo and others added 2 commits June 16, 2022 16:38
Co-authored-by: Max <42641081+bmoxb@users.noreply.github.com>
@chesedo chesedo merged commit 6a11b03 into main Jun 20, 2022
@chesedo chesedo deleted the feat/rds branch June 20, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants