Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shuttle.rs 🚀 #45

Merged
merged 24 commits into from
Mar 14, 2022
Merged

feat: shuttle.rs 🚀 #45

merged 24 commits into from
Mar 14, 2022

Conversation

thecotne
Copy link
Contributor

@thecotne thecotne commented Mar 8, 2022

No description provided.

@thecotne thecotne marked this pull request as ready for review March 9, 2022 10:39
@thecotne thecotne requested a review from brokad March 9, 2022 10:41
Copy link
Collaborator

@brokad brokad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Just one nit about the dead code for Fathom and PostHog which I assume will be removed when telemetry gets rolled out.

www/pages/404.tsx Outdated Show resolved Hide resolved
www/package.json Outdated Show resolved Hide resolved
www/lib/constants.ts Outdated Show resolved Hide resolved
www/lib/helpers.ts Outdated Show resolved Hide resolved
www/components/NoSsr.tsx Show resolved Hide resolved
@thecotne
Copy link
Contributor Author

@brokad can you review this again and we should merge this if its ok right?

@thecotne thecotne requested a review from brokad March 14, 2022 08:55
Copy link
Collaborator

@brokad brokad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the crate name!

www/components/Hero.tsx Outdated Show resolved Hide resolved
Co-authored-by: Damien <damienbroka@mailbox.org>
@thecotne thecotne merged commit aeb8508 into main Mar 14, 2022
@brokad brokad deleted the feat/www branch March 22, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants