feat: rename delete to stop #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jdrouet! This looks like it's nearly there, but won't we still get an FK error from calling |
|
@oddgrd good point, thank you for noticing it 😉 |
oddgrd
approved these changes
Feb 9, 2023
Sure, I'm used to have a clippy job that would break on the CI for this kind of issues so I tend to forget to check 😅 |
According to [this comment](shuttle-hq#616 (comment)), it's not necessary to remove the service from the database and we only need to stop it. So we can rename the `delete_service` function to `stop_service` and just remove the persistence line for dropping the service in database. Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Considering this endpoint no longer deletes the service but just stops it, we can rename the delete command to stop. Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
jdrouet
force-pushed
the
561-rename-delete-to-stop
branch
from
1a4c56a
to
eb57dd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this comment, it's not necessary to remove the service from the database and we only need to stop it.
So, in the deployer, we can rename the
delete_servicefunction tostop_serviceand just remove the persistence line for dropping the service in database.Considering this endpoint no longer deletes the service but just stops it, we can rename the delete command to stop in cargo-shuttle.
This should fix #561