Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auth] feat: axum with routes #632

Merged
merged 8 commits into from
Feb 15, 2023
Merged

[auth] feat: axum with routes #632

merged 8 commits into from
Feb 15, 2023

Conversation

chesedo
Copy link
Contributor

@chesedo chesedo commented Feb 15, 2023

No description provided.

chesedo
chesedo commented Feb 15, 2023
View reviewed changes
gateway/src/api/latest.rs Outdated Show resolved Hide resolved
oddgrd
oddgrd approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I need to work on it for a bit to get a complete understanding, but I think this is good to go. I added a few questions I had.

The failing test works for me locally, maybe it needs a longer sleep in CI? 🤷

common/src/backends/metrics.rs Show resolved Hide resolved
common/src/backends/metrics.rs Show resolved Hide resolved
@chesedo chesedo merged commit b7bcbe1 into shuttle-hq:main Feb 15, 2023
@chesedo chesedo deleted the feature/eng-432-axum-with-routes branch February 15, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chesedo @oddgrd