cargo shuttle init does not handle directory argument properly

[jonaro00]

First invocation: The init command fails when the directory does not exist.

Second invocation: When directory exists, the command still asks for directory, even though it was provided. I manually typed it again.

---

Env: WSL 2, Ubuntu 22.04
Shuttle: 0.11.0
Rust and cargo: 1.66.1

[h-dav]

I’ll sort this

[d2weber]

Also, I noticed that, when I create a new project, the name in Cargo.toml seems to be wrong:

/tmp/pwd$ cargo shuttle init --axum
How do you want to name your project? It will be hosted at ${project_name}.shuttleapp.rs.
✔ Project name · myname

Where should we create this project?
✔ Directory · .

     Created library (shuttle) package

✔ Do you want to create the project environment on Shuttle? · no

/tmp/pwd$ rg name Cargo.toml 
2:name = "pwd"

Should I create a new issue?

[oddgrd]

As of #706, which will be released on monday, the directory argument will now be properly handled. It will not error, it will create the dir and present the path to it in the where would you like to create this project. I'll not close this issue yet, since we might want to improve it further. Do we want to prompt the user for a path at all if they gave one in the command? Also, should we make the command require --path <path> so it's more clear what the command does?

Regarding the naming @d2weber, yes, I think an issue for that is good. Did it really name your project "pwd"? 😂

[jonaro00]

Great!

Do we want to prompt the user for a path at all if they gave one in the command?

This defeats the purpose of having the command line argument...? So I think no.

Also, should we make the command require --path <path> so it's more clear what the command does?

I also think this is not necessary, since basically all "init" commands work this way.

Other comments

I just remembered: The prompt for project name could use a reminder to (Choose a unique name).

The crate name that gets put into Cargo.toml might be incorrect: When doing init with project name hello-world and folder name hello and choosing yes for creating env, the creation request fails when trying to create a project hello-world (Is my guess; By the way, the error message should include the name that already existed, to be extra clear), but the crate is named hello after the folder name. This means that if attempting a new project new (without Shuttle.toml name), it attempts to use hello.

TLDR; The crate shall be named the same as the project OR a Shuttle.toml should be generated with proper name OR/AND the init command shall prompt the user for a new project name if the name already existed.

[oddgrd]

This is great, thanks @jonaro00! So to summarize the name fixes:

• Generating a shuttle.toml with the project name
• Suggesting to the user to pick a unique name
• If the name is taken, show it in the error message when creating a problem (this may be made redundant in the init command if we don't error on name taken, but can be useful for other calls to project new)
• If the name is taken, don't error, rather prompt to enter a new name and try to create a project again
• And for the path issue, I agree with you, we can remove the directory prompt if they entered a path to the init command

Would you mind opening a new issue for this? And of course, if you'd like to work on this yourself we'd be happy to answer any questions you may have 🙂

[oddgrd]

On second thought, we should review #705 before opening another issue for init.

I'm also closing this issue since the path issue has been resolved.