feat: commit generated proto files #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This commit uses a test to compile and generate the
.protofiles, which we then commit, and with the test running in CI we ensure that the generated files are up-to-date if any changes are made to the.protofiles. This means the protobuf compiler does not need to be installed to compileshuttle-proto, which also means it won't be required to install thecargo-shuttleCLI.Protoc will still be required to run/build shuttle projects until we update
opentelemetry-otlpto 0.19, which has been released, we just need to wait fortracing-opentelemtryto be updated as well (or do it ourselves). After upgrading these cratesprotocwill no longer be required for shuttle users, it will only be required to make changes to the.protofiles inshuttle-proto.With this PR we should also be able to remove the protoc install from the binary builds.
Big thanks to @sd2k for suggesting this solution, this PR is largely based on their PR to tonic-health: hyperium/tonic#1065
How Has This Been Tested (if applicable)?
Added a test in
shuttle-protoand ranPROTOC="" cargo build -p cargo-shuttle.