fix: secrets not archived in workspace crates #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianbarbu
reviewed
Apr 11, 2023
| let secrets_path = dir_entry.path().join("Secrets.toml"); | ||
|
|
||
| // Make sure to add any `Secrets.toml` files in the subdirectories. | ||
| if secrets_path.exists() { |
There was a problem hiding this comment.
Should we check this path points to a file and not a directory?
There was a problem hiding this comment.
I'm not sure we need to since we join Secrets.toml to it. I think it is technically still a valid directory name, but in the event that anyone names a dir in their project Secrets.toml I think it will just be added as an empty dir to the archive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR ensures that not only Secrets.toml's in the workspace root are included in the archive, but also Secrets.toml's in crates in the workspace (even if .gitignored).
TODO: fix static files not working in workspace projects.Static folders must be placed in the root of the workspace.How Has This Been Tested (if applicable)?
By running deployer locally.