Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: pre-installed environment on deploy build machines #807

Closed
1 task done
virtualritz opened this issue Apr 20, 2023 · 1 comment · Fixed by #960
Closed
1 task done

[Feature]: pre-installed environment on deploy build machines #807

virtualritz opened this issue Apr 20, 2023 · 1 comment · Fixed by #960
Labels
T-Improvement Improvement or addition to existing features

Comments

@virtualritz
Copy link

Describe the feature

This is related to #703.

It is not uncommon that a project may depend on crates that wrap code in other languages.
To have a hassle free experience at least the build tools for the most common cases should be installed on the machine that handles the shuttle deploy build step.

I would assume this to be at least what a GH runner comes pre-installed with.

See here for what this entails on the resp. target platform/OS.

I would suggest starting with a C/C++ compiler and I would have some projects to test this.

Suggestion or Example of how the feature would be used

No response

Duplicate declaration

  • I have searched the issues and this feature has not been requested before.
@virtualritz virtualritz changed the title [Feature]: pre-installed build environment on deploy build machines [Feature]: pre-installed environment on deploy build machines Apr 20, 2023
@oddgrd oddgrd added the T-Improvement Improvement or addition to existing features label Apr 21, 2023
@oddgrd
Copy link
Contributor

oddgrd commented Apr 24, 2023

Thanks for the issue and the research! Judging what common dependencies are likely to be needed on what the GH runner uses makes a lot of sense.

So we are planning some changes to the deployer in the next couple of months that will affect how we do this. We are planning to no longer build services in the same container as they are started, but rather have a separate builder service (which we plan to use nix for, @chesedo is working on this and maybe able to elaborate). To include the dependencies you suggest should be simple when that is complete.

We can still get started on this in the meantime, by simply adding the dependencies we want in the deployer/prepare.sh script. I think the dependencies you require and suggested are a good place to start (C/C++ compiler). If you'd like to implement this a PR would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Improvement Improvement or addition to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants