Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Show deployment metadata in deployment table #981

Closed
1 task done
jonaro00 opened this issue Jun 7, 2023 · 1 comment · Fixed by #987
Closed
1 task done

[Improvement]: Show deployment metadata in deployment table #981

jonaro00 opened this issue Jun 7, 2023 · 1 comment · Fixed by #987
Labels
Good First Issue Good for newcomers T-Improvement Improvement or addition to existing features

Comments

@jonaro00
Copy link
Member

jonaro00 commented Jun 7, 2023

Describe the improvement

Part 2 of #941

#943 added more metadata to deployments.
The task is to add this info to the cargo shuttle deployment list table.
Beware that screen width is limited, so perhaps only the first 7 chars of the commit id and first ~20(?) chars of the commit message are needed, play around and see what is suitable.

  • Start by expanding the response model of get_deployments() in deployer/src/handlers/mod.rs
  • Then, extend the table in get_deployments_table() in cargo-shuttle/src/lib.rs

Duplicate declaration

  • I have searched the issues and this improvement has not been requested before.
@jonaro00 jonaro00 added T-Improvement Improvement or addition to existing features Good First Issue Good for newcomers A-cargo-shuttle labels Jun 7, 2023
@Fuzzicles
Copy link
Contributor

This looks interesting! I wanted to get my local development server setup before commenting, and I just got it working. I'm unfamiliar working in a codebase this large, but I'll give it a shot and see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers T-Improvement Improvement or addition to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants