New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computation of commonSize #1

Open

maltesilber opened this issue Sep 11, 2023 · 0 comments

maltesilber commented Sep 11, 2023

Hi @shuuchen,
I have a question regarding your code.
In the function sumNormalizedFeatures we compute the commonSize with

commonWidth = startSize[0] / 2**(levels/2 - 1)
commonHeight = startSize[1] / 2**(levels/2 - 1)

I do not quite understand why we devide by 2**(levels/2 - 1). Which would be 2**3.5. Shoudn't it be

commonWidth = startSize[0] / 2**((levels-1)/2)
commonHeight = startSize[1] / 2**((levels-1)/2)

Which would leave us with 2**4=16. This makes more sense to me since the reduction factor at scale 4 is 1:16. Or am I misunderstanding something?

Thanks in advance :)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment