-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-empty-class-body auto-correction leaves spacing when file ends with {} #109
Comments
The bug in question is that the i.e. if you have: Which means if you ran ktlint again, |
Thank you, @thauk-copperleaf. This particular issue is fixed (see commit above). |
@shyiko I had the same code change pending but I didn't want to submit a PR without a unit test :) Thanks for the fix :) |
@shyiko As for the forcing |
@thauk-copperleaf tests on Windows are now green (https://ci.appveyor.com/project/shyiko/ktlint/build/master.3) (#110 resolved). |
@shyiko Thanks for the quick replies! BTW, any plans for a "missing newline at end of file" rule? Many tools warn/error about that (including git). |
@thauk-copperleaf it's supported but not enabled by default (#103). We plan to change this in the next release. |
@shyiko Excellent! Thanks! |
I am trying to write a test case for a bug I found, but I'm on Windows 7, and I've just noticed that there's a hardcoded expectations in the unit tests that the line terminators are
\n
. Is this already known & expected?The text was updated successfully, but these errors were encountered: