KtLint gives wrong autoCorrect flag to custom rule.

[MyDogTom]

Overview
My custom rule always receives autoCorrect = false, regardless that I'm calling emit with canBeAutocorrected = true.

Description
My custom rule is a copy of IndentationRule, but with enabled autocorrection. It means that both rules detect same error in same place. IndentationRule emits error with canBeAutocorrected = false, my CustomIndentationRule emits error with canBeAutocorrected = true

How to reproduce.
I have repository which show case the problem. https://github.com/MyDogTom/ktlint-custom-rules/tree/fix-format (branch fix-format)
It has intentional indent violation.
Auto correction works only when I remove autoCorrect check. See this commit

For sure, it somehow conflicts with standard IndentionRule, but it shouldn't. Unfortunately, I couldn't quickly figure out where is problem.

[MyDogTom]

As experiment, I removed IndentionRule from StandardRuleSetProvider. Behavior stayed the same. Autocorrection happens only when I remove if (autoCorrect) from CustomIndentationRule. At least bug it's not related to the fact that one rule is a copy of another. I still cannot find why that happens. Any help is really welcome :)

[shyiko]

$ ktlint --version
0.15.0

$ cat A.kt 
fun main(
    args: String) {
println("")
}

$ ktlint -R com.github.MyDogTom:ktlint-custom-rules:master-SNAPSHOT A.kt -v
/tmp/A.kt:2:17: Parenthesis should be on new line (custom:class-and-function-header-format)

$ ktlint -R com.github.MyDogTom:ktlint-custom-rules:master-SNAPSHOT A.kt -F
<no output>

$ ktlint -R com.github.MyDogTom:ktlint-custom-rules:master-SNAPSHOT A.kt -v
<no output>

Looks like everything is OK (at least in ktlint@0.15.0).
Can you provide an example with a different behavior?

[MyDogTom]

Sure.

fun main(args: String) {
   println("")
}

ktlint -R com.github.MyDogTom:ktlint-custom-rules:master-SNAPSHOT A.kt -v

A.kt:2:1: Unexpected indentation (3) (it should be 4) (indent)
A.kt:2:1: Unexpected indentation (3) (it should be 4) (custom:indent)

ktlint -R com.github.MyDogTom:ktlint-custom-rules:master-SNAPSHOT A.kt -F

A.kt:2:1: Unexpected indentation (3) (it should be 4)

ktlint -R com.github.MyDogTom:ktlint-custom-rules:master-SNAPSHOT A.kt -v

A.kt:2:1: Unexpected indentation (3) (it should be 4) (indent)
A.kt:2:1: Unexpected indentation (3) (it should be 4) (custom:indent)

[shyiko]

Fix available in 0.15.1 (Maven Central sync might take up to 25 minutes). 🎈

[MyDogTom]

Thank you for quick fix. I've checked new version via brew and it works! Unfortunately, new version is still not available via Maven/JCenter.

[shyiko]

@MyDogTom thank you for letting me know. https://issues.sonatype.org/browse/OSSRH-37894 submitted.

[shyiko]

@MyDogTom it looks like Maven Central sync finally took place

[MyDogTom]

Thank you!