-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common root package #280
Comments
You can test it in this project: https://github.com/mhlz/kotlin-issue Either run ktlint from the command line or run mvn install. ktlint fails with
|
I see... Thank you, @mhlz. Reopening... |
I have this issue as well with https://gitlab.com/serebit/diskord. Using the |
So, I looked into fixing this myself, but it seems kinda difficult to do with the way that rules currently work. We'd need some sort of "module" wide state to determine the root package. Otherwise it's going to be hard to support all use cases. Maybe as a quick fix, it'd be good to disable this rule again? I'd like to keep following and recommending the JetBrains coding conventions, but with ktlint going against them it's kinda hard. |
Currently ktlint flags package names as invalid, if you're following the recommendation outlined in the coding conventions:
I'd like for ktlint to be able to support this directory structure as it cuts down on the nesting a lot. IntelliJ does not generate warnings (anymore) either, when following this recommendation.
The text was updated successfully, but these errors were encountered: