Apply parameter-list-wrapping when max_line_length is exceeded
#200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsim
force-pushed
the
parameter-list-wrapping-with-max-line-length
branch
from
76bc6f8
to
bc091fd
Compare
|
@shyiko not really sure why this is failing on the AppVeyor build. Tests run fine locally, and the test failures in AppVeyor don't seem to suggest there's actually anything wrong with the output. I'm currently guessing it has something to do with AppVeyor being Windows based, and how it pulls down Git code: https://help.appveyor.com/discussions/problems/3954-test-failure-cause-by-different-newlines Not sure why it isn't posing a problem for any of the other tests though. Any ideas? |
Resolves pinterest#96 This commit applies `parameter-list-wrapping` and its associated linting/formatting when `max_line_length` is exceeded by a function or class declaration due to its parameter list being too long. It will also apply for nested function declarations.
ntsim
force-pushed
the
parameter-list-wrapping-with-max-line-length
branch
from
bc091fd
to
41559ca
Compare
shyiko
added a commit
that referenced
this pull request
Apr 30, 2018
|
Not to worry (15b284f should take care of that). Thank you for the PR, Nicholas! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #96
This commit applies
parameter-list-wrappingand its associated linting/formatting whenmax_line_lengthis exceeded by a function or class declaration due to its parameter list being too long. It will also apply for nested function declarations.