Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommentSpacingRule: Exclude //noinspection. #212

Merged
merged 1 commit into from
May 16, 2018
Merged

CommentSpacingRule: Exclude //noinspection. #212

merged 1 commit into from
May 16, 2018

Conversation

vanniktech
Copy link
Contributor

Is there any magic that one needs to do in order to execute the tests?

gradle test didn't quite work.

@shyiko
Copy link
Collaborator

shyiko commented May 16, 2018

./mvnw clean verify should do it.
Thanks for the PR, Niklas!

@shyiko shyiko merged commit cb6b5cb into pinterest:master May 16, 2018
@vanniktech
Copy link
Contributor Author

Any reason why there are two build systems used here?

@vanniktech vanniktech deleted the CommentSpacingRule branch May 16, 2018 21:07
@shyiko
Copy link
Collaborator

shyiko commented May 16, 2018

@vanniktech Google's internal build infrastructure does not support Maven. Gradle scripts here are for their convenience. #102

@vanniktech
Copy link
Contributor Author

Ah good to know. It's a pity for everyone who wants to contribute though as they're super confused - just like me.

@shyiko
Copy link
Collaborator

shyiko commented May 16, 2018

I'll update the README. #213

@vanniktech
Copy link
Contributor Author

Would it be possible to cut a new release with this?

@shyiko
Copy link
Collaborator

shyiko commented Jun 18, 2018

@vanniktech sure, I'll do it within the next couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants