Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outliers in Preview plots #4

Closed
lweasel opened this issue Oct 8, 2020 · 3 comments
Closed

Remove outliers in Preview plots #4

lweasel opened this issue Oct 8, 2020 · 3 comments
Labels
wontfix This will not be worked on

Comments

@lweasel
Copy link
Contributor

lweasel commented Oct 8, 2020

The main distribution plots have outliers hidden, using the "outlier.shape = NA" option of geom_boxplot(). I think that we should do the same for the plots in the Preview tab - unfortunately, it looks like there is some weird behaviour in plotly which stops this working?

plotly/plotly.R#1114

I wonder if we could try some of the workarounds suggested there?

@lweasel lweasel added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Oct 8, 2020
@zkozic
Copy link
Collaborator

zkozic commented Oct 13, 2020

If I remember correctly, plotly does ignore outlier.shape argument. The only way to remove it was to remove a specific layer of the plot that contains the outlier points. On main plots it was always the same layer so it could be removed, but on Preview plots it somehow varied.

@lweasel lweasel added wontfix This will not be worked on and removed enhancement New feature or request labels Oct 13, 2020
@lweasel
Copy link
Contributor Author

lweasel commented Oct 13, 2020

Ok, it seems that we already went through this a while back and agreed that (i) there's not a lot that we can do about it, due to the behaviour of plotly (hopefully they might fix at some point), and (ii) that it was acceptable since it only affects the Preview plots. So I'll close this for now.

@lweasel lweasel closed this as completed Oct 13, 2020
@lweasel
Copy link
Contributor Author

lweasel commented Oct 26, 2020

I don't know if this has any value as a possible replacement for the interactivity provided by plotly:

https://davidgohel.github.io/ggiraph/index.html

Just noting it down in case we ever want to return to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants