Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates doesn't work with angular 1.2.0 #29

Closed
dddpaul opened this issue Nov 13, 2013 · 4 comments
Closed

Templates doesn't work with angular 1.2.0 #29

dddpaul opened this issue Nov 13, 2013 · 4 comments

Comments

@dddpaul
Copy link

dddpaul commented Nov 13, 2013

This example:

{{hours}} hours, {{minutes}} minutes, {{seconds}} seconds.

renders into:

hours, minutes, seconds.

@siddii
Copy link
Owner

siddii commented Nov 13, 2013

Appears to be related to angular/angular.js#3558

@olegbl
Copy link

olegbl commented Nov 14, 2013

I've had luck by replacing all "$scope.$seconds", minutes, etc with "$scope.$parent.$seconds", minutes, etc so that they're not in an isolate scope. Of course, "$scope.$digest()" also needs to be replaced with "$scope.$parent.$digest()".

@tdumitrescu
Copy link
Contributor

@olegbl that solution will get you your interpolation, but makes it impossible to use multiple independent timers within the same parent scope (and of course pollutes the parent scope, producing potential collisions with other scope vars named seconds, minutes, etc).

i have a small fix which involves treating dynamic templated content the same way as the default (<span>{{millis}}</span>) within the controller; i'll submit a pull request soon.

@siddii
Copy link
Owner

siddii commented Nov 27, 2013

@siddii siddii closed this as completed Nov 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants