Skip to content

Commit

Permalink
fix: remove extra logging on ethtool ioctl failures
Browse files Browse the repository at this point in the history
We should ignore this, it's a totally an optional feature used in
containers (Talos on its own kernel has ethtool-netlink).

Fixes #9296

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit a9269ac)
  • Loading branch information
smira committed Sep 13, 2024
1 parent 5eb5ff5 commit 9e60f17
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions internal/app/machined/pkg/controllers/network/link_status.go
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,7 @@ func (ctrl *LinkStatusController) reconcile(

if ethState == nil {
state, err := ethtoolIoctlClient.LinkState(link.Attributes.Name)
if err != nil {
logger.Warn("error querying ethtool ioctl link state", zap.String("link", link.Attributes.Name), zap.Error(err))
} else {
if err == nil {
ethState = &ethtool.LinkState{
Interface: ethtool.Interface{
Index: int(link.Index),
Expand Down

0 comments on commit 9e60f17

Please sign in to comment.