Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Native M1 ARM Support #139

Open
whispy opened this issue Dec 28, 2020 · 2 comments
Open

Add Native M1 ARM Support #139

whispy opened this issue Dec 28, 2020 · 2 comments

Comments

@whispy
Copy link

whispy commented Dec 28, 2020

πŸ€·πŸ½β€β™‚οΈ Current Behaviour

PB4D runs using the Intel architecture on an M1 Macbook. This is less performant, as it is running emulated using Apple's Rosetta 2.

🎯 Expected Behaviour

PB4D would be recompiled to run using the native ARM architecture.

🏑 Environmental Context

App Version
v11.0.2
Installation Type
Default
Operating System
macOS 11.0.1 on an Apple M1 Macbook

@autolyticus
Copy link

autolyticus commented Jul 21, 2021

I believe that most of the dependencies, including electron-builder does support darwin-arm64. However, by trying to bump the version of electron to 11 (which is the earliest version that supports it) and adding the arm64 target for mac, it did build and package successfully, but it still threw an error on startup stating that this.init is not a function with regards to the traymenu. @sidneys I do not have enough know-how how to fix this and would be willing to work on this and submit a PR if I had some pointers.

According to this (https://www.electronjs.org/blog/apple-silicon). Rosetta-based electron requires two JITs (one for the V8 and once again for Rosetta), I think that it would be great for battery life and performance if we could have an arm64 package.

@autolyticus
Copy link

Have encountered some kind of memory leak issues and very high CPU utilization with the Rosetta implementation as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants