-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doesn't work since node 6.4 #8
Comments
Thanks! I think node 6.4 is more strict about writing zero length string at the end of the buffer ( because length is there there would be no OOB write anyway but check does error earlier ) |
This line Line 54 in a62b5d7
need to be wrapped in something like if (payload.length > 0) {
buf.write(payload, payloadOffset);
} Also need to add changes similar to sidorares/node-mysql2#381 Would you be able to try this yourself and make PR @FlorianLeroux ? |
The fix work |
example:
stdout:
node version 6.4.0
node-i3 version 0.2.0
i3 version 4.12
work perfecly with node 6.3.1
The text was updated successfully, but these errors were encountered: