-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate deque from denque to Js-sdsl Deque #1629
Comments
Thanks for the offer, I'll try to evaluate Js-sdsl! |
Hey, I done th migrate. See #1633. How can I know the result about benchmark? |
@js-sdsl/deque published! |
@ZLY201 I don't want to change core functionality that already works fine without convincing benchmarks ( in the context of drivers use case ). I believe Js-sdsl is more performant than denque but need to see some visible difference (with all other components factored in). if its below statistical error not worth the change It's not that I'm against this change, just until there is a good benchmark its a low priority for me |
Thanks to your reply! We are trying to find a good way to test the performance of Js-sdsl in MySQL like database connections, including Redis and MongoDB. This will be our main work in the next stage. So make this progress to be pending is reasonable. |
@ZLY201 you got your definitions wrong It's |
Sorry about that, I got it wrong. Thanks for reminding me! |
Hey! I'm the developer of Js-sdsl. Official website: https://js-sdsl.github.io/.
Now, we published the version 4.1.4.
I see you are using denque.
In benchmark, we have confirmed that Js-sdsl is several times faster than
denque
and nearly equal toArray.push
in the case of push elements.We would like to invite you to migrate deque related functions to Js-sdsl v4.1.4 and I am willing to submit a pull request for this change.
Looking forward to your reply! :D
The text was updated successfully, but these errors were encountered: