Update events that are propegated from pool cluster to include remove

[Michael03]

Removed events from promise wrapper that aren't fired by pool cluster.
I've seperated this into 2 commits. The first adds a failing test the second fixes that test

[sidorares]

Thanks @Michael03
I personally never used PoolCluster so maybe worth someone else to have a look but overall happy to merge.

One suggestion: could you move the affected test to under test/builtin-runner/* and rewrite it to use describe/it?

[sidorares]

actually that test file is way too big. Maybe worth factoring out PoolCluster test into separate file and add it to tests managed with a new runner

[Michael03]

Ill get that refactored 👍

[wellwelwel]

Looking into lib/pool_cluster.js, it contains only these events from PoolCluster class:

• _increaseErrorCount
  

  node-mysql2/lib/pool_cluster.js

  Line 247 in 9051caf

  this.emit('remove', node.id);

• _getConnection
  

  node-mysql2/lib/pool_cluster.js

  Line 264 in 9051caf

  this.emit('warn', err);

Then, LGTM 🤹🏻‍♀️

---

Resolved

It just needs to pattern the change from promise.d.ts to typings/mysql/lib/PoolCluster.d.ts 🙋🏻‍♂️

- on(event: 'connection', listener: (connection: PoolConnection) => void): this;
+ on(event: 'warn', listener: (err: Error) => void): this;

node-mysql2/typings/mysql/lib/PoolCluster.d.ts

Line 83 in facc68c

on(event: 'connection', listener: (connection: PoolConnection) => void): this;