Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setMaxParserCache throws TypeError #2757

Merged

Conversation

constb
Copy link
Contributor

@constb constb commented Jun 11, 2024

replace parser cache with a new one on setMaxParserCache to avoid TypeError, because max is now read-only on LRU caches and cannot be altered.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.33%. Comparing base (d74e0d7) to head (4dc09a9).

Files Patch % Lines
lib/parsers/parser_cache.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2757   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files          71       71           
  Lines       15731    15731           
  Branches     1345     1345           
=======================================
  Hits        14210    14210           
  Misses       1521     1521           
Flag Coverage Δ
compression-0 90.33% <50.00%> (ø)
compression-1 90.33% <50.00%> (ø)
tls-0 89.85% <50.00%> (ø)
tls-1 90.13% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel
Copy link
Collaborator

wellwelwel commented Jun 11, 2024

Hi @constb, thanks 🚀


About the codecov/patch CI, as you changed a file that was no longer covered, it blocks the CI, even though it's not related to your changes.

This PR allows to continue showing the alerts, but without blocking the CI due to files individually:

@wellwelwel wellwelwel linked an issue Jun 11, 2024 that may be closed by this pull request
@wellwelwel wellwelwel changed the title fix #2752 setMaxParserCache throws TypeError fix: setMaxParserCache throws TypeError Jun 11, 2024
@sidorares sidorares merged commit aa8604a into sidorares:master Jun 13, 2024
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug][regression] mysql2.setMaxParserCache fails with TypeError
3 participants